Skip to content

Revert "[BB-3622] Port the add course creation condition for organisation for koa.3"#430

Merged
Agrendalath merged 1 commit intoopencraft-release/koa.3from
revert-423-farhaan/bb-3622-port-for-koa
Oct 14, 2021
Merged

Revert "[BB-3622] Port the add course creation condition for organisation for koa.3"#430
Agrendalath merged 1 commit intoopencraft-release/koa.3from
revert-423-farhaan/bb-3622-port-for-koa

Conversation

@Agrendalath
Copy link
Member

@Agrendalath Agrendalath commented Oct 14, 2021

This reverts #423.

It's breaking the Studio with the following traceback:

Traceback (most recent call last):
  File "/edx/app/edxapp/venvs/edxapp/lib/python3.8/site-packages/django/core/handlers/exception.py", line 34, in inner
    response = get_response(request)
  File "/edx/app/edxapp/venvs/edxapp/lib/python3.8/site-packages/django/core/handlers/base.py", line 115, in _get_response
    response = self.process_exception_by_middleware(e, request)
  File "/edx/app/edxapp/venvs/edxapp/lib/python3.8/site-packages/django/core/handlers/base.py", line 113, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/usr/lib/python3.8/contextlib.py", line 75, in inner
    return func(*args, **kwds)
  File "/edx/app/edxapp/venvs/edxapp/lib/python3.8/site-packages/django/contrib/auth/decorators.py", line 21, in _wrapped_view
    return view_func(request, *args, **kwargs)
  File "/edx/app/edxapp/venvs/edxapp/lib/python3.8/site-packages/django/utils/decorators.py", line 142, in _wrapped_view
    response = view_func(request, *args, **kwargs)
  File "/edx/app/edxapp/edx-platform/cms/djangoapps/contentstore/views/course.py", line 571, in course_listing
    'libraries': [format_library_for_view(lib, request) for lib in libraries],
  File "/edx/app/edxapp/edx-platform/cms/djangoapps/contentstore/views/course.py", line 571, in <listcomp>
    'libraries': [format_library_for_view(lib, request) for lib in libraries],
TypeError: format_library_for_view() takes 1 positional argument but 2 were given

We should revert this because it's a common branch and it will affect all of our clients after redeployments.

@Agrendalath Agrendalath self-assigned this Oct 14, 2021
farhaanbukhsh
farhaanbukhsh approved these changes Oct 14, 2021
View reviewed changes
Copy link
Member

@farhaanbukhsh farhaanbukhsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

  • ✅ I tested this: provisioning a koa.3 stack and changing to opencraft-release branch, once you try creating a library and then visiting the library view page you will see this error.
  • ✅ I read through the code
  • ✅ I checked for accessibility issues
  • ✅ Includes documentation
  • ✅ I made sure any change in configuration variables is reflected in the corresponding client's configuration-secure repository.

@Agrendalath Agrendalath merged commit 7013c2c into opencraft-release/koa.3 Oct 14, 2021
@Agrendalath Agrendalath deleted the revert-423-farhaan/bb-3622-port-for-koa branch October 14, 2021 20:22
@farhaanbukhsh farhaanbukhsh mentioned this pull request Oct 27, 2021
Merged
1 task
@0x29a
Copy link

0x29a commented Oct 28, 2021

@Agrendalath, @farhaanbukhsh

Ah, I'm sorry for not spotting this in the original PR. I've read the code, but blindly followed only the admin part from the upstream PR test instructions. Should have tested Studio as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@farhaanbukhsh farhaanbukhsh farhaanbukhsh approved these changes

@0x29a 0x29a Awaiting requested review from 0x29a

Assignees

@Agrendalath Agrendalath

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Agrendalath @0x29a @farhaanbukhsh